Skip to content

Complete the documentation of the legacy mode #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Complete the documentation of the legacy mode #1190

merged 2 commits into from
Jun 24, 2025

Conversation

@tguenneguez
Copy link
Contributor

@tguenneguez tguenneguez commented Sep 6, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 6, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 6, 2023
@tguenneguez
Copy link
Contributor Author

tguenneguez commented Dec 7, 2023

Some reviewer ?

@github-actions github-actions bot removed the Stale label Dec 8, 2023
@lecaros lecaros requested review from lecaros and removed request for lecaros February 22, 2024 14:00
@lecaros
Copy link
Contributor

lecaros commented Feb 22, 2024

@nokute78 can you please validate this is accurate? I saw some code of yours in the grep filter :)

@nokute78
Copy link
Contributor

nokute78 commented Feb 23, 2024

@lecaros This patch is for legacy mode and it was implemented by @edsiper

I sent a following patch to support legacy.
legacy means a first implementation of filter_grep.
fluent/fluent-bit#6721

@github-actions
Copy link

github-actions bot commented May 23, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 23, 2024
@lecaros lecaros requested review from a team as code owners March 25, 2025 14:34
@github-actions github-actions bot removed the Stale label Mar 26, 2025
@github-actions
Copy link

github-actions bot commented Jun 24, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 24, 2025
@tguenneguez
Copy link
Contributor Author

tguenneguez commented Jun 24, 2025

Who check this PR ?

@patrick-stephens
Copy link
Contributor

patrick-stephens commented Jun 24, 2025

We cannot merge as there are conflicts so if you can update can take a look

@tguenneguez
Copy link
Contributor Author

tguenneguez commented Jun 24, 2025

Yes, I can take a look, but only if somebody look quickly.

@lecaros lecaros merged commit 38bd1ce into fluent:master Jun 24, 2025
5 checks passed
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
@tguenneguez
Complete the documentation of the legacy mode (fluent#1190)
796ded8 
Signed-off-by: tguenneguez <[email protected]>
Signed-off-by: Tom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tguenneguez @lecaros @nokute78 @patrick-stephens