Skip to content

Conversation

@soedar
Copy link

@soedar soedar commented Sep 29, 2023

Updated elasticsearch output docs to include additional cloud_apikey setting.

Ref: fluent/fluent-bit#7935

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 12, 2024
@soedar soedar force-pushed the out-es-cloudapikey branch from 05c8a5c to d152079 Compare January 12, 2024 03:41
@soedar
Copy link
Author

soedar commented Jan 12, 2024

rebased

@github-actions github-actions bot removed the Stale label Jan 13, 2024
@lecaros lecaros requested review from a team as code owners March 25, 2025 14:34
@eschabell eschabell requested a review from esmerel October 22, 2025 18:56
@eschabell eschabell added conflict Waiting on conflict to be resolved by contributor waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
@eschabell
Copy link
Collaborator

@esmerel would you mind reviewing and looking at the conflicts here?

@eschabell eschabell self-assigned this Oct 22, 2025
@esmerel
Copy link
Contributor

esmerel commented Oct 23, 2025

@esmerel would you mind reviewing and looking at the conflicts here?

I fixed the conflicts, but it would be good if you doublechecked the code sample from lines 357-374 - I don't know if this is valid or not, so there are two outputs in there.

@eschabell eschabell removed the conflict Waiting on conflict to be resolved by contributor label Nov 4, 2025
Copy link
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soedar The spacing on the code example should be 2 for indenting, not the 4 submitted here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing for configuration files should indent 2, not 4.

@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes and removed waiting-on-review Waiting on a review from mainteners labels Nov 4, 2025
@soedar
Copy link
Author

soedar commented Nov 5, 2025

Closed via #1727

@soedar soedar closed this Nov 5, 2025
@eschabell eschabell removed waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-code-merge labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants