in_kafka: Add async_commit description #1385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HaChanHo <[email protected]>
7 tasks
lockewritesdocs
previously requested changes
May 30, 2024
Contributor
lockewritesdocs
left a comment
lockewritesdocs
left a comment
There was a problem hiding this comment.
Left a suggestion to change the language a bit. Thanks!
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: champ-ion <[email protected]>
Contributor
|
When #8894 merges, I'll get this one merged as well. Thanks @HaChanho! |
Collaborator
|
@HaChanho can you resolve the conflicts here in this PR? I've nudged you on the same for the corresponding code PR fluent/fluent-bit#8894 to see if we can get these merged. |
eschabell
added
waiting-for-user
Signed-off-by: Lynette Miles <[email protected]>
esmerel
dismissed
lockewritesdocs’s stale review
this has had heavy editing since Adam's request.
Contributor
|
I fixed the conflict and made the addition consistent with our guidelines. |
esmerel
removed
conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR is: fluent/fluent-bit#8894