-
Notifications
You must be signed in to change notification settings - Fork 540
adding openobserve details for fluentbit output #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding openobserve details for fluentbit output #1472
Conversation
50cb61a to
2ab866f
Compare
lockewritesdocs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggested changes. Thanks for your contribution @chaitanya-sistla!
patrick-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New files need adding to the SUMMARY.md otherwise they won't appear.
|
Thank you @patrick-stephens I have added that to SUMMARY.md |
|
Can you sort the DCO requirements as well? That's a hard requirement for merge I'm afraid. You can see the failing check above which should tell you what to do: https://github.com/fluent/fluent-bit-docs/pull/1472/checks?check_run_id=31507263224 |
Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]>
Signed-off-by: Chaitanya Sistla <[email protected]>
9db8a27 to
16de651
Compare
|
I took care of this @patrick-stephens |
lockewritesdocs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest changes, looks good from a technical writing perspective. If @patrick-stephens is 👍 , then we should be all set.
|
Amazing, thanks @lockewritesdocs and @patrick-stephens |
|
Can we update the description a bit? Just a bit of context - blank descriptions always make me suspicious :) |
|
@patrick-stephens I have updated the description :) Please let me know if this helps. |
|
Cheers, can you send a PR for 3.1 branch so we can see it in the live docs now as well? |
|
sure and @patrick-stephens when i open https://docs.fluentbit.io/manual/3.2-dev/pipeline/outputs/openobserve i see blank. |
* adding openobserve details for fluentbit output Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * Update pipeline/outputs/openobserve.md Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> * adding openobserve in summary Signed-off-by: Chaitanya Sistla <[email protected]> --------- Signed-off-by: Chaitanya Sistla <[email protected]> Signed-off-by: Chaitanya Sistla <[email protected]> Co-authored-by: Chaitanya Sistla <[email protected]> Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Tom <[email protected]>
Description:
This PR adds OpenObserve (O2) as a supported output destination for Fluent Bit, allowing users to forward logs seamlessly to O2. The integration works without any code or implementation changes, as Fluent Bit's existing configuration system can handle the output forwarding.
Context:
There isn't an open issue for this feature, but adding OpenObserve as an output destination can provide users with an efficient logging solution. Since no code modifications are necessary, this update can be applied without concerns. Yes this can be used for 3.1 as well and we can include it there.