Skip to content

Conversation

@jakobjoachim
Copy link
Contributor

No description provided.

@jakobjoachim jakobjoachim requested review from a team as code owners November 1, 2024 14:01
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jakobjoachim! I added some suggested changes to incorporate for style.

@lockewritesdocs
Copy link
Contributor

@jakobjoachim, can you please sign the DCO?

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

@lecaros lecaros added waiting-for-user Waiting for user/contributors feedback or requested changes dco DCO failing labels Nov 7, 2024
Jakob Joachim and others added 2 commits November 8, 2024 10:27
@jakobjoachim
Copy link
Contributor Author

should be done now @lockewritesdocs

@lockewritesdocs lockewritesdocs self-requested a review November 19, 2024 14:34
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakobjoachim! I pushed a minor change to update the formatting of a field from bold to code style. Approved 👍

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 18, 2025
@esmerel esmerel merged commit aa94275 into fluent:master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco DCO failing Stale waiting-for-user Waiting for user/contributors feedback or requested changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants