in_statsd: Add a description for Metrics parameter #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
Contributor
|
No description tax :) Is this requiring a code change or already implemented? |
Contributor
Author
|
Oh, sorry. I updated a description for this PR. :) |
Co-authored-by: Pat <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Co-authored-by: Pat <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-metrics-on-in_statsd
branch
from
9806335 to
f02d01d
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
patrick-stephens
approved these changes
Jan 9, 2025
Contributor
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
Looks ok to me from technical side, I'll leave with @fluent/chronosphere-tech-writers to review wordage :)
Member
|
since the feature is part of the release, let's merge it.. in the meanwhile @fluent/chronosphere-tech-writers can review it and update it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this doc for already implement metrics parameter for in_statsd plugin.
This was implemented in v3.1.6 and here is the PR: fluent/fluent-bit#9119