Skip to content

Conversation

@alexakreizinger
Copy link
Member

this adds a few changes to the conditional processing PR that was merged yesterday.

#1598

@alexakreizinger alexakreizinger requested review from a team as code owners April 3, 2025 19:13
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line break but otherwise 👍🏼

Conditional processing is only available for
[YAML configuration files](../../administration/configuring-fluent-bit/yaml/README.md),
not [classic configuration files](../../administration/configuring-fluent-bit/classic-mode/README.md).
Conditional processing is only available for [YAML configuration files](../../administration/configuring-fluent-bit/yaml/README.md), not [classic configuration files](../../administration/configuring-fluent-bit/classic-mode/README.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Conditional processing is only available for [YAML configuration files](../../administration/configuring-fluent-bit/yaml/README.md), not [classic configuration files](../../administration/configuring-fluent-bit/classic-mode/README.md).
Conditional processing is only available for [YAML configuration files](../../administration/configuring-fluent-bit/yaml/README.md),
not [classic configuration files](../../administration/configuring-fluent-bit/classic-mode/README.md).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it like that previously but gitbook got mad so I think it's safer to leave it all on one line :|

image

(no space between "for" and "YAML", and then it seems to take the linebreak too literally after "files")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH RIGHT, forgot it does that.

@alexakreizinger alexakreizinger merged commit 45a9ff7 into master Apr 3, 2025
5 checks passed
@alexakreizinger alexakreizinger deleted the conditional-processing-fixes branch April 3, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants