installation: windows: Fix Service creation C:\Program Files via PowerShell #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hampus Reis <[email protected]>
Signed-off-by: Hampus Reis <[email protected]>
esmerel
approved these changes
Apr 21, 2025
Contributor
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
Seems completely reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
C:\Program Files\fluent-bit\is the default install location for fluent-bit it makes sense that the documentation supports this.The current work-around doesn't make sense when it can easily be resolved by simply escaping the quotation marks.
This should give new users a better experience as the documentation follows a default installation.
Feel free to remove/ignore the -Description commit, I just think it gives a more concise and proper look inline with how most Windows services look and feel.