-
Notifications
You must be signed in to change notification settings - Fork 541
Added documentation page for traces processor #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…age for traces. Signed-off-by: Eric D. Schabell <[email protected]>
Signed-off-by: Eric D. Schabell <[email protected]>
Added documentation page for traces feature. Fixes issue #1611.
patrick-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo but otherwise looks ok
Signed-off-by: Eric D. Schabell <[email protected]>
|
@patrick-stephens Just noticed that the sidebar does not generate the entry for traces. And the page for traces is linked into the repo... not in the docs site... not sure how to fix that? |
|
Ah you have to add the new page to the index, missed that but it's pretty common and we should really catch it with CI or be nicer to have a preview. Check the recent PR that added the filters as processors one is probably the easiest way to see. |
|
I can add it, I'll do a separate PR. |
|
Added it here: #1615 |
* Added traces to pipeline main page and started on new documentation page for traces. Signed-off-by: Eric D. Schabell <[email protected]> * Finished traces documentation, adding two images for the doc page. Signed-off-by: Eric D. Schabell <[email protected]> * Fixed typo in tail sampling paragraph. Signed-off-by: Eric D. Schabell <[email protected]> --------- Signed-off-by: Eric D. Schabell <[email protected]> Signed-off-by: Tom <[email protected]>

This is a new documentation page for the traces feature in Processors with the following additions:
Resolves #1611