Change to name Sampling instead of Traces in documentation. Fixes #1618. #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1618. Signed-off-by: Eric D. Schabell <[email protected]>
Contributor
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
Change itself looks fine but any reason we changed all the bulleted list types?
Member
|
I recommend not touching files that are not part of the main change |
Contributor
I'm not sure it's necessary as part of this change but we recommend using - instead of * for bulleted lists in general. It prevents confusion and accidents with italics or bolding. |
Collaborator
Author
|
There is a single change in that file, but it looks like my code editor auto "fixed" that.... must be some standard. I'll fix that and update the PR. |
Signed-off-by: Eric D. Schabell <[email protected]>
patrick-stephens
approved these changes
May 1, 2025
TomlinfreeGit
pushed a commit
to TomlinfreeGit/fluent-bit-docs
that referenced
this pull request
Oct 28, 2025
…ent#1618. (fluent#1619) * Change to name Sampling instead of Traces in documentation. Fixes issue fluent#1618. Signed-off-by: Eric D. Schabell <[email protected]> * Fixed list items to use star and not dash. Signed-off-by: Eric D. Schabell <[email protected]> --------- Signed-off-by: Eric D. Schabell <[email protected]> Signed-off-by: Tom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved traces to sampling naming convention in docs.