Skip to content

Turning on error test for curly quotes #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Turning on error test for curly quotes #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,11 @@ possible. For example:
### Vale

The Fluent Bit maintainers use the [Vale](https://vale.sh/docs/) plugin, which lints
pull requests and adds suggestions to improve style and clarity.
pull requests and adds suggestions to improve style and clarity. Most Vale tests are
at the `suggestion` level and will not block merging.

The following tests are at a `warning` level and will prevent merging:

- NonStandardQuotes: Use standard quotes. Google docs use curly quotes. Copy and
pasting from Google docs requires correcting the quotes. You can
[turn off smart quotes](https://support.google.com/docs/thread/217182974/can-i-turn-smart-quotes-off-in-a-google-doc?hl=en).
2 changes: 1 addition & 1 deletion vale-styles/FluentBit/NonStandardQuotes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
extends: existence
message: 'Use standard single quotes or double quotes only. Do not use left or right quotes.'
level: suggestion
level: error
ignorecase: true
scope: raw
raw:
Expand Down