Skip to content

Conversation

@devin-andrenam
Copy link

Documentation update in association with according PR to fluent bit.

@devin-andrenam devin-andrenam requested review from a team as code owners May 29, 2025 03:23
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic change. A @fluent/fluent-bit-maintainers should doublecheck the definition for technical accuracy, but I'm otherwise ok with this.

@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 21, 2025
@eschabell
Copy link
Collaborator

@devin-andrenam while waiting on the code PR changes fluent/fluent-bit#10398 you need to make, would you please fix the conflicts here so I'm ready to merge your docs update when we can?

@esmerel
Copy link
Contributor

esmerel commented Oct 21, 2025

Conflict was due to formatting changes for style. I reverified so the submitter doesn't need to.

@esmerel esmerel removed conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes labels Oct 21, 2025
@patrick-stephens
Copy link
Contributor

There are on changes?

Signed-off-by: Lynette  Miles <[email protected]>
@esmerel
Copy link
Contributor

esmerel commented Oct 21, 2025

Appears I overwrote the change fixing the conflict, I corrected it. I was afraid I'd done that at least once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants