-
Notifications
You must be signed in to change notification settings - Fork 541
pipeline: inputs: prometheus-remote-write: general cleanup #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: inputs: prometheus-remote-write: general cleanup #1842
Conversation
Signed-off-by: Alexa Kreizinger <[email protected]>
| # Prometheus remote write | ||
|
|
||
| This input plugin allows you to ingest a payload in the Prometheus remote-write format, i.e. a remote write sender can transmit data to Fluent Bit. | ||
| The _Prometheus remote write_ input plugin lets you ingest a payload in the Prometheus remote-write format. A remote-write sender can transmit data to Fluent Bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "remote-write" be hyphenated like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's how the prometheus remote-write protocol spec formats it, so I think so: https://prometheus.io/docs/specs/prw/remote_write_spec/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, looking at this again, they're somewhat inconsistent. but I think it makes sense to hyphenate :P
| With the above configuration, Fluent Bit will listen on port `8080` for data. | ||
| You can now send payloads in Prometheus remote write format to the endpoint `/api/prom/push`. | ||
| These sample configurations configure Fluent Bit to listen for data on port `8080`. You can send payloads in Prometheus remote-write format to the endpoint `/api/prom/push`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about hyphenation.
cnorris-cs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left comments and suggestions, but I've added my approval based on those to keep this moving.
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: Alexa Kreizinger <[email protected]>
…t-docs-pipeline-inputs-prometheus Signed-off-by: Alexa Kreizinger <[email protected]>
this PR is part of the effort to meet guidelines for style, clarity, and consistency.