Update installation on ubuntu commands #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove $CODENAME that doesn't work properly Signed-off-by: Mohammed Abdallah <[email protected]>
installation/linux/ubuntu.md
Outdated
|
|
||
| ```bash | ||
| echo "deb [signed-by=/usr/share/keyrings/fluentbit-keyring.gpg] https://packages.fluentbit.io/ubuntu/${CODENAME} ${CODENAME} main" | sudo tee /etc/apt/sources.list.d/fluent-bit.list | ||
| echo "deb [signed-by=/usr/share/keyrings/fluentbit-keyring.gpg] https://packages.fluentbit.io/ubuntu/$(grep -oP '(?<=VERSION_CODENAME=).*' /etc/os-release || lsb_release -cs) $(grep -oP '(?<=VERSION_CODENAME=).*' /etc/os-release || lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/fluent-bit.list |
Contributor
There was a problem hiding this comment.
I think we need to redirect stderr for lsb_release messages, otherwise you can get extra lines of output like No LSB modules are available.
- Redirect stderr messages, to not get extra lines of output like No LSB modules are available. - Separate the codename variable to be more efficient and readable Signed-off-by: Mohammed Abdallah <[email protected]>
cosmo0920
approved these changes
Jul 28, 2025
TomlinfreeGit
pushed a commit
to TomlinfreeGit/fluent-bit-docs
that referenced
this pull request
Oct 28, 2025
* Update installation on ubuntu commands remove $CODENAME that doesn't work properly Signed-off-by: Mohammed Abdallah <[email protected]> * Update installation on ubuntu - Redirect stderr messages, to not get extra lines of output like No LSB modules are available. - Separate the codename variable to be more efficient and readable Signed-off-by: Mohammed Abdallah <[email protected]> --------- Signed-off-by: Mohammed Abdallah <[email protected]> Signed-off-by: Tom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove $CODENAME that doesn't work properly