-
Notifications
You must be signed in to change notification settings - Fork 540
Updated configuration variables for opentelemetry output plugin, many new ones added. Fixes #2083 #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tory. Signed-off-by: Eric D. Schabell <[email protected]>
…orrect description file. Signed-off-by: Eric D. Schabell <[email protected]>
…ixes fluent#2108. Signed-off-by: Eric D. Schabell <[email protected]>
… new ones added. Signed-off-by: Eric D. Schabell <[email protected]>
… new ones added. Fixes fluent#2083 Signed-off-by: Eric D. Schabell <[email protected]>
|
@esmerel would you mind reviewing this PR? Can we figure out these issues with Vale, seeing them every time now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation should have corresponding values of out_opentelemetry plugins' config_map here:
https://github.com/fluent/fluent-bit/blob/master/plugins/out_opentelemetry/opentelemetry.c#L893-L1116
I found glitches of default values and applying mechanism of add_label.
These should be needed to reflect the actual behavior and the default values.
…ut plugin. Signed-off-by: Eric D. Schabell <[email protected]>
|
@cosmo0920 thanks and if you'd like to review the latest update for the OpenTelemetry output plugin options table? |
|
Merging as the vale plugin fixes need are not terminal. |
… new ones added. Fixes fluent#2083 (fluent#2110) * Removing a readme file this is not standardized in classic-mode directory. Signed-off-by: Eric D. Schabell <[email protected]> * Updated to not use readme file in classic-config directory, but the correct description file. Signed-off-by: Eric D. Schabell <[email protected]> * Updated to better sort some sections and update for missing entries. Fixes fluent#2108. Signed-off-by: Eric D. Schabell <[email protected]> * Updated configuration variables for opentelemetry output plugin, many new ones added. Signed-off-by: Eric D. Schabell <[email protected]> * Updated configuration variables for opentelemetry output plugin, many new ones added. Fixes fluent#2083 Signed-off-by: Eric D. Schabell <[email protected]> * Fixes reqeusted by reviewers for options table for opentelemetry output plugin. Signed-off-by: Eric D. Schabell <[email protected]> --------- Signed-off-by: Eric D. Schabell <[email protected]> Signed-off-by: Tom <[email protected]>
Updated configuration variables for opentelemetry output plugin, many new ones added. Fixes #2083