Skip to content

Conversation

@eschabell
Copy link
Collaborator

Updated prom textfile input plugin docs with configuration options table available for v4.1. Fixes #2081.

@eschabell eschabell requested a review from cosmo0920 October 28, 2025 15:49
@eschabell eschabell self-assigned this Oct 28, 2025
@eschabell eschabell requested a review from a team as a code owner October 28, 2025 15:49
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 28, 2025
@eschabell eschabell requested a review from a team as a code owner October 28, 2025 15:49
@eschabell
Copy link
Collaborator Author

@cosmo0920 would you mind a review of the configuration options table updates here?

@eschabell eschabell requested a review from esmerel October 28, 2025 15:57
@eschabell
Copy link
Collaborator Author

@esmerel if you have time, a review of my configuration table changes is welcome.

Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions, otherwise looks good to me

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

Fixed single quotes to codify the boolean values in options  table description.

Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Eric D. Schabell <[email protected]>
@eschabell
Copy link
Collaborator Author

Applied small change by @esmerel and merging!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Oct 29, 2025
@eschabell eschabell merged commit 13f1738 into fluent:master Oct 29, 2025
7 checks passed
@eschabell eschabell deleted the erics_prom_textfile_inputs branch October 29, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing 4.1 feature documentation - Prometheus Textfile input

3 participants