Updated log to metrics filter configuration options table to support v4.1. Fixes #2092. #2124
+29
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory. Signed-off-by: Eric D. Schabell <[email protected]>
…orrect description file. Signed-off-by: Eric D. Schabell <[email protected]>
…ixes fluent#2108. Signed-off-by: Eric D. Schabell <[email protected]>
… new ones added. Signed-off-by: Eric D. Schabell <[email protected]>
… new ones added. Fixes fluent#2083 Signed-off-by: Eric D. Schabell <[email protected]>
…ut plugin. Signed-off-by: Eric D. Schabell <[email protected]>
fluent#2088. Signed-off-by: Eric D. Schabell <[email protected]>
…v4.1. Fixes fluent#2092. Signed-off-by: Eric D. Schabell <[email protected]>
|
@esmerel would you mind reviewing the table layout from this update? |
|
@cosmo0920 if you have time to review these configuration option updates? |
cosmo0920
requested changes
Oct 29, 2025
…ket variable description. Applys to fluent#2124. Signed-off-by: Eric D. Schabell <[email protected]>
|
@cosmo0920 thanks for the feedback, addressed and pushed update for review! |
Signed-off-by: Eric D. Schabell <[email protected]>
esmerel
approved these changes
Oct 29, 2025
Grammar issue in option description fixed. Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Eric D. Schabell <[email protected]>
Grammar issue in option description fixed. Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Eric D. Schabell <[email protected]>
Forgot the ending period in option description! Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Eric D. Schabell <[email protected]>
Better clarity in option description added. Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Eric D. Schabell <[email protected]>
Grammar fix to option description. Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Eric D. Schabell <[email protected]>
|
All suggestions applied and fixes added, thanks much @esmerel and @cosmo0920, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated log to metrics filter configuration options table to support v4.1. Fixes #2092.