- 
                Notifications
    
You must be signed in to change notification settings  - Fork 540
 
in_http: add_remote_addr #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
in_http: add_remote_addr #2130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestions are stylistic for page consistency. They're fairly minor. This looks good to me otherwise, but should have a technical review for final approval.
        
          
                pipeline/inputs/http.md
              
                Outdated
          
        
      | 
               | 
          ||
| ### Add remote addr | ||
| 
               | 
          ||
| Adds a REMOTE_ADDR field to the records. The value of REMOTE_ADDR is the client's address, which is extracted from the X-Forwarded-For header. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Adds a REMOTE_ADDR field to the records. The value of REMOTE_ADDR is the client's address, which is extracted from the X-Forwarded-For header. | |
| This field adds a `REMOTE_ADDR` field to the records. The value of `REMOTE_ADDR` is the client's address, which is extracted from the `X-Forwarded-For` header. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add_remote_addr is technically a configuration option, not a field itself, but when activated (when set to true) it will result in a field (REMOTE_ADDR) being added to each event/record.
So perhaps:
The `add_remote_addr` configuration option, when activated, adds a `REMOTE_ADDR` field to the records. The value of `REMOTE_ADDR` is the client's address, which is extracted from the `X-Forwarded-For` header.
Thoughts?
Signed-off-by: Alexandre Létourneau <[email protected]>
bc93bab    to
    867a1fb      
    Compare
  
    
Corresponds to: fluent/fluent-bit#11080