Add json.escape_unicode option to service configuration #2131
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
from
50b5c77 to
35afdc1
Compare
owanio1992
changed the title
cosmo0920
requested changes
Nov 2, 2025
administration/configuring-fluent-bit/classic-mode/configuration-file.md
Outdated
Show resolved
Hide resolved
administration/configuring-fluent-bit/yaml/configuration-file.md
Outdated
Show resolved
Hide resolved
|
@owanio1992 Could you add Signed-off line in your commit? Under the fluent organization repos, we request to use commit signs for every contributors. |
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
2 times, most recently
from
7327cc7 to
99100bd
Compare
|
I'll come back for a tech writing review once @cosmo0920 's requested changes are done =) |
cosmo0920
reviewed
Nov 4, 2025
There was a problem hiding this comment.
For technical perspective, it looks good.
But DCO still complains that the author and the commiter information differs like:
Commit sha: 99100bd, Author: owan, Committer: owan; Expected "owan [email protected]", but got "owanio1992 [email protected]".
eschabell
added
waiting-for-user
|
@owanio1992 if you can look at the DCO failures this can be reviewed by @esmerel. |
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
2 times, most recently
from
b745e02 to
2a4e588
Compare
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
5 times, most recently
from
2e06f6b to
9daaeb3
Compare
Signed-off-by: owanio1992 <[email protected]>
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
from
9daaeb3 to
9c63970
Compare
|
@cosmo0920 I update description and default value, please review again |
esmerel
reviewed
Nov 4, 2025
administration/configuring-fluent-bit/classic-mode/configuration-file.md
Outdated
Show resolved
Hide resolved
administration/configuring-fluent-bit/yaml/configuration-file.md
Outdated
Show resolved
Hide resolved
cosmo0920
approved these changes
Nov 5, 2025
Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: owan <[email protected]>
…on-file.md Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: owan <[email protected]>
Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: owan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature source PR: fluent/fluent-bit#10665
This commit adds the
json.escape_unicodeoption to the service configuration for both classic and YAML modes.This option allows users to control the encoding of raw UTF-8 strings when serializing MessagePack records to JSON.