filter_grep: grep with arithmetic operators #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Diez <[email protected]>
eschabell
added
conflict
|
@esmerel can you please review this PR, as I've nudged the owner of the corresponding code PR fluent/fluent-bit#5449 to move that forward too. |
Signed-off-by: Lynette Miles <[email protected]>
esmerel
approved these changes
Oct 27, 2025
Signed-off-by: Lynette Miles <[email protected]>
patrick-stephens
requested changes
Nov 5, 2025
| | `Regex` | `KEY REGEX` | String | Keep records in which the content of `KEY` matches the regular expression. | | ||
| | `Exclude` | `KEY REGEX` | String | Exclude records in which the content of `KEY` matches the regular expression. | | ||
| | `number_equal` | `KEY NUMBER` | number | Keep records in which the content of `KEY` is equal to `NUMBER`. | | ||
| | `number_not_equal` | `KEY NUMBER` | number | Keep records in which the content of `KEY` is not equal to `NUMBER`. | |
There was a problem hiding this comment.
I'm not a fan of this, why have we removed the logical_op as well?
I would expect us to add additional operators really rather than weird looking text strings.
It needs examples, e.g. to show precedence and conflict resolution when you define multiple rules for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for fluent/fluent-bit#5449