Skip to content

lib: luajit: only require a C compiler#10318

Merged
edsiper merged 1 commit intofluent:masterfrom
ThomasDevoogdt:bugfix/lib-luajit-only-require-a-c-compiler
Jun 4, 2025
Merged

lib: luajit: only require a C compiler#10318
edsiper merged 1 commit intofluent:masterfrom
ThomasDevoogdt:bugfix/lib-luajit-only-require-a-c-compiler

Conversation

@ThomasDevoogdt
Copy link
Contributor

@ThomasDevoogdt ThomasDevoogdt commented May 8, 2025

@ThomasDevoogdt
Copy link
Contributor Author

ThomasDevoogdt commented May 9, 2025

@cosmo0920 Can you also check this one, and add the milestone tag?

@cosmo0920
Copy link
Contributor

luajit-cmake's upstream is here: https://github.com/zhaozg/luajit-cmake
But this repo does not seem actively to accept external contributors' PRs.
Is this adding milestone tag good way to us, @edsiper ?

Upstream: zhaozg/luajit-cmake#17
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/lib-luajit-only-require-a-c-compiler branch from 9bb0163 to d9a90a6 Compare May 12, 2025 12:42
@ThomasDevoogdt
Copy link
Contributor Author

luajit-cmake's upstream is here: https://github.com/zhaozg/luajit-cmake But this repo does not seem actively to accept external contributors' PRs. Is this adding milestone tag good way to us, @edsiper ?

I added an upstream PR for it. zhaozg/luajit-cmake#17

@ThomasDevoogdt
Copy link
Contributor Author

@edsiper @cosmo0920 Upstream has merged this commit, so I think it can be merged here.

@cosmo0920
Copy link
Contributor

I'm going to process other commits for cross compiling of ARM64 on x86_64 platform. So, we should hold on this patch for now.

@ThomasDevoogdt
Copy link
Contributor Author

ThomasDevoogdt commented May 31, 2025

I'm going to process other commits for cross compiling of ARM64 on x86_64 platform. So, we should hold on this patch for now.

Hi, can you also consider #9600 if you're busy with fixing cross compiling issues?

cosmo0920

This comment was marked as off-topic.

@cosmo0920
Copy link
Contributor

cosmo0920 commented Jun 4, 2025

I use approved status to mark this PR is valid but we need to merge the bundled libraries should be merged into upstream at first and we'll merge the changes with upstream syncs.

@edsiper edsiper merged commit a8f3f50 into fluent:master Jun 4, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments