-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TLS : OpenSSL Provider and Store API support to support HSMs #10622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brent-Crawley-GGL
wants to merge
25
commits into
fluent:master
Choose a base branch
from
Brent-Crawley-GGL:brentc/openssl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ac03d76
config: Added OpenSSL Provider support via configuration
Brent-Crawley-GGL be1541d
tls: Add Provider Query and OpenSSL Store Support
Brent-Crawley-GGL 88a49bd
lib: Allow TLS to configure global settings for Provider support
Brent-Crawley-GGL 52c5a50
build: Compile flag for OpenSSL Store support
Brent-Crawley-GGL 1c1d236
input: Implement Provider Query and use to initialise TLS context
Brent-Crawley-GGL 573fff2
output: Implement Provider Query and use to initialise TLS context
Brent-Crawley-GGL aeb12ca
upstream_node: Implement Provider Query and use to initialise TLS con…
Brent-Crawley-GGL 7a2ac67
oauth2: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL ed7db45
aws_credentials: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 51f63b5
s3: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 442e136
opensearch: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 4e87956
kinesis_streams: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL bb94272
kinesis_firehose: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 2ae901d
es: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 9145b28
cloudwatch_logs: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL cecf0af
bigquery: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 6d289d6
azure_kusto: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 7b840e7
azure_blob: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 487c223
kubernetes_events: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL e9b44d9
nightfall: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 3129e3c
kubernetes: Update the TLS interface for OpenSSL Provider support
Brent-Crawley-GGL 267fef3
Merge branch 'master' into brentc/openssl
Brent-Crawley-GGL 60f5cb8
tls: updated the OpenSSL defines
Brent-Crawley-GGL 92b7bac
tests : tcp : Fixed up missing arguments
Brent-Crawley-GGL 691e52a
tls: Added missing function declarations
Brent-Crawley-GGL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Wrong option name in fatal error; define macro consistently; and gate after OpenSSL detection
Minimal immediate fix within this block:
Then, add the actual gating and macro definition right after OpenSSL discovery (near Lines 720–724). This makes the check accurate and the error actionable:
Notes:
To ensure this behaves well across platforms (as requested by reviewers), please validate CMake configuration on at least Linux, macOS, and Windows with:
Example configure invocations:
If you want, I can open a follow-up PR to wire a CMake configure-time summary that prints “OpenSSL Store: ENABLED/DISABLED (version)”.
🏁 Script executed:
Length of output: 336
🏁 Script executed:
Length of output: 2691
🏁 Script executed:
Length of output: 1528
Correct and relocate OpenSSL Store gating and definition
FLB_OPENSSL_STORE
(notFLB_ENABLE_OPENSSL_STORE
).add_definitions(-DFLB_USE_OPENSSL_STORE=1)
with the project’sFLB_DEFINITION(FLB_USE_OPENSSL_STORE)
helper for consistency.find_package(OpenSSL)
(around line 721) and:FLB_USE_OPENSSL_STORE
viaFLB_DEFINITION
.Minimal diff for the early block (around lines 423–431):
Then, immediately after the existing TLS/OpenSSL discovery block (near line 721), add:
This ensures immediate, clear failures on missing or too-old OpenSSL, keeps macro definitions consistent, and aligns with the rest of the project’s CMake conventions.
🤖 Prompt for AI Agents