Skip to content

in_forward: fix segfault and double-free in trace path handling [Backport to 4.1] #11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cosmo0920 merged 1 commit into from
Dec 9, 2025
Merged

in_forward: fix segfault and double-free in trace path handling [Backport to 4.1] #11267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/in_forward/fw_prot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,8 +1146,8 @@ static int append_log(struct flb_input_instance *ins, struct fw_conn *conn,
else if (event_type == FLB_EVENT_TYPE_TRACES) {
off = 0;
ret = ctr_decode_msgpack_create(&ctr, (char *) data, len, &off);
if (ret == -1) {
flb_error("could not decode trace message. ret=%d", ret);
if (ret != CTR_DECODE_MSGPACK_SUCCESS) {
flb_plg_error(ins, "could not decode trace message. ret=%d", ret);
return -1;
}

Expand All @@ -1159,7 +1159,7 @@ static int append_log(struct flb_input_instance *ins, struct fw_conn *conn,
ctr_decode_msgpack_destroy(ctr);
return -1;
}
ctr_decode_msgpack_destroy(ctr);
/* Note: flb_input_trace_append takes ownership of ctr and destroys it on success */
}

return 0;
Expand Down