in_syslog: add expansion for ident and msg-id in tag #1720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edsiper, is this something that could be considered upstream? It would be pretty useful in some cases, given that tag manipulation is not really supported yet by Fluent Bit. |
edsiper
requested changes
May 5, 2020
Member
|
Sorry for the late reply.
|
edsiper
added
the
waiting-for-user
bemyak
force-pushed
the
syslog-enhancements
branch
from
1e36019 to
061d1cd
Compare
bemyak
force-pushed
the
syslog-enhancements
branch
from
061d1cd to
cfc9049
Compare
Allow * in tag, e.g. syslog/*/*/. Wildcard chars are to be expanded to <ident> and <msg-id> fields. One and only * is expanded to <ident>, and an optional, second * is expanded to <msg-id>. A test runtime/in_syslog.c has been added to verify the tag expansion functionality - it does not involve any real syslog service. Signed-off-by: Sergej Gureev <sergej.gureev@relex.fi>
bemyak
force-pushed
the
syslog-enhancements
branch
from
cfc9049 to
c17a8f5
Compare
Contributor
|
Please rebase your latest changes if still interested to land this functionality. If not, please let me know to close this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
*in tag, e.g.syslog/*/*/. Wildcard chars are to be expanded to <ident> and <msg-id> fields.One and only
*is expanded to <ident>, and an optional, second*is expanded to <msg-id>.A test
runtime/in_syslog.chas been added to verify the tag expansion functionality - it does not involve any real syslog service.Signed-off-by: Ji-Ping Shen ji-ping.shen@relexsolutions.com