lib: tutf8e: Updated API to support conversion of invalid input input #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Well.. seems to be working (tests in High Sierra macOS). Got rid of extra function layer. Good. One thing I don't really like at all is tutf8e_encoder function. We could live this just to get something done.. probably too late for 1.5 anyway. |
|
Thanks for looking. My time on this was a bit limited, tried to stick to the essentials. |
bluebike
added a commit
to bluebike/fluent-bit
that referenced
this pull request
Aug 4, 2020
Add flb_encoding functions for charset encodings to utf8. * Uses lib/tutf8e-library. * Only 8-bit source charsets are supported. * Encoding options (//OPTION) : //IGNORE, //QUESTION, //REPLACEMENT ///<text> * This commit doesn't add support to any input plugin. * Depends on fluent#2326 Signed-off-by: Jukka Pihl <[email protected]>
4 tasks
|
@nigels-com well... this is good enough. Seems to be working. |
…cters Signed-off-by: Nigel Stewart <[email protected]>
nigels-com
force-pushed
the
tutf8e-invalid-characters
branch
from
a3c018d to
133d80c
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up for PR #1703 and PR #1757 and as an alternative to PR #2287.
Extend the "Tiny UTF-8 Encoder" library API to optionally handle invalid input characters.
A UTF-8 encoded string can be specified for substituting invalid input characters, rather than erroring.
If the invalid parameter is NULL, invalid input characters will not be tolerated.
Testing
Valgrind of test harness is clean on Ubuntu 18.04.
Documentation
Documentation updates not required for this.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.