out_file: new property to control output file append at the end line #5169
Conversation
EKwongChum
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
plugins/out_file/file.c
Outdated
| { | ||
| FLB_CONFIG_MAP_BOOL, "line_append", "false", | ||
| 0, FLB_TRUE, offsetof(struct flb_file_conf, line_append), | ||
| "Append new data to the end off log in same line. Default value is false" |
There was a problem hiding this comment.
Typo here, should be "of" not "off"
patrick-stephens
changed the title
|
Can you fill in the details required in the template? Be good to have example config, plus valgrind etc. |
|
Hi @patrick-stephens . |
Yes please and link it here so we know to wait for code merge |
nokute78
left a comment
nokute78
left a comment
There was a problem hiding this comment.
I added some comments for maintainability.
Here is the PR for Doc. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@nokute78 are you happy with this now? |
|
@patrick-stephens I confirmed they were fixed. @EKwongChum Sorry for late reply. |
Signed-off-by: ekwongchum <[email protected]>
Thanks for your reply and friendly tips about commit message style. Commit message is updated. It is very honor since this pull request is reopen. |
|
Unfortunately the second commit is incorrect now, can you update it as well to follow the same style? Make sure the commits pass the DCO check as well: it'll tell you what is wrong if you click on it. Essentially they need to have the |
> Co-authored-by: Pat <[email protected]> Signed-off-by: ekwongchum <[email protected]>
|
Hi. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@patrick-stephens can you review this now that @EKwongChum addressed your changes? |
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
Looks ok now but we need to rebase in order to trigger CI properly and ensure we are up-to-date for merging.
4 participants
Feature #5170
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Doc PR is here770
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Test Part 1
when add new property
line_append truein service conf output itemExample configuration file as below:
[service] flush 5 grace 10 daemon on log_file /tmp/ekwongchum/flb.log log_level debug [input] Name tail Tag syslog Path /var/log/syslog DB /tmp/ekwongchum/syslog.db [output] Name file Match syslog Path /tmp/ekwongchum/ File record.file Mkdir true Format template Template {log} line_append truedebug log output as below:
and log file show here:
and record file is here
Test Part 2
when add new property
line_append falsein service conf output itemExample configuration file as below:
[service] flush 5 grace 10 daemon on log_file /tmp/ekwongchum/flb.log log_level debug [input] Name tail Tag syslog Path /var/log/syslog DB /tmp/ekwongchum/syslog.db [output] Name file Match syslog Path /tmp/ekwongchum/ File record.file Mkdir true Format template Template {log} line_append falsedebug log output as below:
and log file show here:
and record file is here
Test Part 3
when no property
line_appendin service conf output itemExample configuration file as below:
[service] flush 5 grace 10 daemon on log_file /tmp/ekwongchum/flb.log log_level debug [input] Name tail Tag syslog Path /var/log/syslog DB /tmp/ekwongchum/syslog.db [output] Name file Match syslog Path /tmp/ekwongchum/ File record.file Mkdir true Format template Template {log}debug log output as below:
and log file show here:
and record file is here