config_format: fix possible double fclose#9795
Open
peter15914 wants to merge 2 commits intofluent:masterfrom
Open
config_format: fix possible double fclose#9795peter15914 wants to merge 2 commits intofluent:masterfrom
peter15914 wants to merge 2 commits intofluent:masterfrom
Conversation
peter15914
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Signed-off-by: peter15914 <48548636+peter15914@users.noreply.github.com>
peter15914
force-pushed
the
fix_double_fclose
branch
from
37fe0f9 to
bd0bd2b
Compare
peter15914
changed the title
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a path of execution that had two calls to
fclose(f).If
fclose(f)on line 738 is called andgoto erroron line 752 is executed, then the secondfclose(f)on line 762 will be called.Therefore, I added
f = NULLto fix the issue.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.