Skip to content

http_client: fix muti part http2 request not working#9818

Merged
edsiper merged 1 commit intofluent:masterfrom
flobz:fix/http2_big_payload
May 19, 2025
Merged

http_client: fix muti part http2 request not working#9818
edsiper merged 1 commit intofluent:masterfrom
flobz:fix/http2_big_payload

Conversation

@flobz
Copy link
Contributor

@flobz flobz commented Jan 10, 2025

When the request body is quite big, it's split but only the first part is send multiple time instead of sending all parts.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

When the request body is quite big and it's split but only the first part is send multiple time instead of sending all parts.

Signed-off-by: Florian Bezannier <florian.bezannier@hotmail.fr>
@flobz
Copy link
Contributor Author

flobz commented Jan 10, 2025

Fluent config:

[SERVICE]
    Flush     1
    Daemon    off
    Log_Level debug


[INPUT]
    Name                 node_exporter_metrics
    Tag                  system_metrics
    Scrape_interval      10

[OUTPUT]
    Name                 opentelemetry
    Match                *
    Host                 127.0.0.1
    Port                 4317
    grpc                 true
    http2                force
    Log_response_payload True
    Tls                  Off

Open telemetry collector config:

receivers:
  otlp:
    protocols:
     grpc:
        endpoint: 0.0.0.0:4317
       
exporters:
      debug:
        verbosity: detailed
service:
  pipelines:
    metrics:
        receivers: [otlp]
        exporters: [debug]
  telemetry:
    logs:
     level: debug
     development: true

Copy link
Contributor

@leonardo-albertovich leonardo-albertovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be correct, thank you!

@leonardo-albertovich
Copy link
Contributor

I backported your patch in PR #10349

Thank you.

@edsiper edsiper merged commit 0ae7e15 into fluent:master May 19, 2025
50 checks passed
@edsiper edsiper added this to the Fluent bit v4.0.3 milestone May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants