Skip to content

package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka#9860

Merged
patrick-stephens merged 8 commits intomasterfrom
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka
Jan 23, 2025
Merged

package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka#9860
patrick-stephens merged 8 commits intomasterfrom
cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka

Conversation

@cosmo0920
Copy link
Contributor

This is because libkafka's SASL OAUTHBEARER mechanism depends on libcurl and OpenSSL.
We already installed a development package of OpenSSL in each of building containers but we didn't install a development package of libcurl.
This leads for degraded usability for rdkafka library and it makes not to be able to use SASL OAUTHBEARER mechanism on kafka plugins like below with #9859 patch:

[2025/01/22 11:55:30] [error] [flb_kafka] cannot configure 'sasl.oauthbearer.method' property with error: 'Configuration property "sasl.oauthbearer.method" not supported in this build: OAuth/OIDC depends on libcurl and OpenSSL which were not available at build time'
[2025/01/22 11:55:30] [error] [flb_kafka] cannot configure 'sasl.oauthbearer.client.id' property with error: 'Configuration property "sasl.oauthbearer.client.id" not supported in this build: OAuth/OIDC depends on libcurl and OpenSSL which were not available at build time'
[2025/01/22 11:55:30] [error] [flb_kafka] cannot configure 'sasl.oauthbearer.client.secret' property with error: 'Configuration property "sasl.oauthbearer.client.secret" not supported in this build: OAuth/OIDC depends on libcurl and OpenSSL which were not available at build time'
[2025/01/22 11:55:30] [error] [flb_kafka] cannot configure 'sasl.oauthbearer.token.endpoint.url' property with error: 'Configuration property "sasl.oauthbearer.token.endpoint.url" not supported in this build: OAuth/OIDC depends on libcurl and OpenSSL which were not available at build time'
[2025/01/22 11:55:30] [ info] [output:kafka:kafka.0] brokers='192.168.1.3:9092' topics='test'

This PR aims to fix this issue.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 added the ok-package-test Run PR packaging tests label Jan 22, 2025
@cosmo0920 cosmo0920 marked this pull request as ready for review January 22, 2025 08:51
@patrick-stephens
Copy link
Contributor

Do we need this in the container images too?

@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jan 23, 2025

Yeah, good point. We need to add it into them.

…afka

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
…OAuth/OICD

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 changed the title package: distro: Install libcurl development package for oauthoicd on rdkafka package: distro: dockerfiles: Install libcurl development package for oauthoicd on rdkafka Jan 23, 2025
@cosmo0920 cosmo0920 force-pushed the cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka branch 6 times, most recently from 26c12b1 to d3b3b18 Compare January 23, 2025 07:26
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka branch from d3b3b18 to 96babaf Compare January 23, 2025 07:38
@cosmo0920 cosmo0920 added this to the Fluent Bit v4.0.0 milestone Jan 23, 2025
@patrick-stephens patrick-stephens merged commit 81f62b9 into master Jan 23, 2025
52 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-install-libcurl-for-oauthoicd-on-rdkafka branch January 23, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-required ok-package-test Run PR packaging tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants