downgrade minimum go version and cleanup actions #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 08fb086 added a go.mod, but set the minimum required version to the patch version. Generally, go versions in go.mod, like other dependencies, follow "MVS" (minimum version selection) conventions, and specify the lowest possible / supported minimum version. Keeping the version low avoids unnecessary code churn in projects using this module. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Also set GOTOOLCHAIN to "local" to prevent changes in go.mod to override the version used in tests. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Omit selecting branches; by default any branch is included. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
GitHub's default timeout is 6 hours, which is really long. Set a more reasonable timeout to prevent "runnaway" runs from running for hours before timing out. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
cc @cosmo0920 ptal |
cosmo0920
approved these changes
Jun 26, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mod: don't enforce go1.23.5 patch version
commit 08fb086 (#131) added a go.mod, but
set the minimum required version to the patch version.
Generally, go versions in go.mod, like other dependencies, follow
"MVS" (minimum version selection) conventions, and specify the lowest
possible / supported minimum version. Keeping the version low avoids
unnecessary code churn in projects using this module.
gha: test against oldest supported and current go versions
Also set GOTOOLCHAIN to "local" to prevent changes in go.mod to
override the version used in tests.
gha: simplify selection of branches
Omit selecting branches; by default any branch is included.
gha: set default permissions to "read" only
gha: set default timeout
GitHub's default timeout is 6 hours, which is really long. Set a
more reasonable timeout to prevent "runnaway" runs from running
for hours before timing out.