Backport(v5): yum: Disable package-note-file to remove unnecessary linker flag (#877) #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can refer the Ruby configure results through `RbConfig::CONFIG`. `RbConfig::CONFIG` is mainly used when installing gems which has C extension. If flags remain that use linker scripts that do not exist in the user's environment, it causes errors when user install the gem. When creating a package using `fluent-package.spec.in`, the environment variable `LDFLAGS` was automatically set as follows. ``` LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -Wl,-dT,/root/rpmbuild/BUILD/fluent-package-6.0.0/.package_note-fluent-package-6.0.0-1.amzn2023.x86_64.ld' ``` Ruby's `configure` refers to the environment variable `LDFLAGS`, and it expands into `RbConfig::CONFIG`. Fix fluent-plugins-nursery/fluent-plugin-node-exporter-metrics#21 Fix #590 --------- Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #877
The user can refer the Ruby configure results through
RbConfig::CONFIG.RbConfig::CONFIGis mainly used when installing gems which has C extension.If flags remain that use linker scripts that do not exist in the user's environment,
it causes errors when user install the gem.
When creating a package using
fluent-package.spec.in, the environment variableLDFLAGSwas automatically set as follows.Ruby's
configurerefers to the environment variableLDFLAGS, and it expands intoRbConfig::CONFIG.Fix
fluent-plugins-nursery/fluent-plugin-node-exporter-metrics#21 Fix #590