Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Oct 2, 2025

This PR will fix backport error in #917

When I solve the conflict, I introduced the error.
Therefore, the yum workflow does not works properly.

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978
Copy link
Contributor Author

Watson1978 commented Oct 2, 2025

@Watson1978 Watson1978 added this to the 5.0.8 milestone Oct 2, 2025
@Watson1978 Watson1978 requested review from daipom and kenhys October 2, 2025 09:02
@daipom
Copy link
Contributor

daipom commented Oct 3, 2025

Thanks!
Hmm, looks like the cause is that we did not backport the following PR.

This was added wrongly at fluent#855.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom
Copy link
Contributor

daipom commented Oct 3, 2025

We also should address the following.

- name: Run Test ${{ matrix.test-file }} on ${{ matrix.container-image }}
run: fluent-package/yum/systemd-test/test.sh ${{ matrix.container-image }} ${{ matrix.test-file }}
- name: Run Test ${{ matrix.test }} on ${{ matrix.container-image }}
run: fluent-package/yum/systemd-test/test.sh ${{ matrix.container-image }} ${{ matrix.test-file }}

The backport #855 added a broken duplicated step.
I have added the commit.

@daipom daipom added the CI label Oct 3, 2025
@Watson1978
Copy link
Contributor Author

The backport #855 added a broken duplicated step.
I have added the commit.

Thanks.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit e8e74ca into fluent:fluent-package-v5 Oct 3, 2025
160 of 162 checks passed
@Watson1978 Watson1978 deleted the fluent-package-v5-fix-backport-error branch October 3, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants