Skip to content

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented May 1, 2025

No description provided.

@kenhys kenhys requested review from Watson1978 and daipom May 2, 2025 08:03
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Do we need to update README as well?

I have noticed -2 has been used for a while for some images.

  • v1.16-2
  • v1.16-debian-amd64-2
  • ...

Don't we have to reset this to -1?

kenhys added 2 commits May 2, 2025 18:32
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented May 2, 2025

Thanks, I've forgot to update README.md.

@kenhys
Copy link
Contributor Author

kenhys commented May 2, 2025

-2 means based on bookworm image, not to let confused, dare to use -2 for v1.16 series at least.

Here is the case which should not be:

  • v1.16.2: v1.16-debian-amd64-1 (bullseye)
  • v1.16.3: v1.16-debian-amd64-2 (bookworm)
    ...
  • v1.16.8: v1.16-debian-amd64-1 (bookworm)

For v1.18 (already set to -1) and upcoming v1.19, it should be reset to -1.

@daipom
Copy link
Contributor

daipom commented May 2, 2025

-2 means based on bookworm image, not to let confused, dare to use -2 for v1.16 series at least.

I see! Thanks!

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kenhys kenhys merged commit 98155ec into v1.16 May 2, 2025
11 checks passed
@kenhys kenhys deleted the bump-v1.16.8 branch May 2, 2025 09:54
@kenhys
Copy link
Contributor Author

kenhys commented May 4, 2025

v1.16.8 images which includes Windows container were deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants