Skip to content

Conversation

@Alainx277
Copy link

What this PR does / why we need it:

It reduces the amount of info logs on startup when using many filters or workers. In normal usage these logs do not provide any valuable information, so we only print them when debugging.

Docs Changes:

Release Note:

@daipom daipom self-requested a review November 21, 2024 03:02
@daipom
Copy link
Contributor

daipom commented Nov 21, 2024

Thanks for this PR!
I see.

Leaving aside the need to address CI, this change looks a bit controversial to me.
It is because these logs only occur when starting and don't repeat themselves.

It would be nice to know the list of plugins actually running, in case of anomalies.
However, we can confirm it by looking at the configuration.

If anyone else has an opinion, please let me know.

By the way, there was some talk that when not setting @id, it might be a good idea to log the automatically determined plugin-id here.

@daipom
Copy link
Contributor

daipom commented Nov 22, 2024

@Alainx277
Thanks for this PR, but I'm considering not merging this.

The motivation for this change is the following:

In normal usage these logs do not provide any valuable information, so we only print them when debugging.

However, it is not correct.
These logs tell us the list of plugins actually running.
That's useful information to some extent in case of anomalies.
(From the config, we can't tell if the config loaded correctly and the plugin actually loaded.)

As an alternative, it might be good to be able to turn off these logs by adding an option to the system_config.
Please discuss such points with us in another issue or PR.

Thanks again!

@daipom daipom closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants