Skip to content

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Jan 6, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
RubyInstaller 3.4.1 was released.
So we can use Ruby 3.4 on Windows in CI.

Docs Changes:

Release Note:

@Watson1978
Copy link
Contributor Author

Hmm, we need [email protected] to use Ruby 3.4 on Windows in CI.
Ref. ruby/setup-ruby@4a9ddd6

@Watson1978
Copy link
Contributor Author

setup-ruby action will be update to v1.207.0 by #4757

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 marked this pull request as ready for review January 6, 2025 04:30
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit b9fc438 into fluent:master Jan 6, 2025
13 checks passed
@Watson1978 Watson1978 deleted the ruby3.4 branch January 6, 2025 05:19
@daipom daipom added this to the v1.19.0 milestone Jan 28, 2025
@daipom daipom added the CI Test/CI issues label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants