Conversation
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
|
@Athishpranav2003 This PR is in draft status. Please let me know if there are any TODO. |
|
Hey @daipom I guess the pr is left to be tested but I didn't get time to test. Maybe I can check it next week but if someone else can do it as well it will be really helpful. Setting up the openssl thing I didn't try it |
|
OK! Thanks! |
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
|
Hey guys i am back, was busy with college. Will look at this pr this week |
|
Testing output |
71cb2aa to
8acba89
Compare
|
Thanks! We will see this soon! |
|
If you rebase your commits with master, It will pass tests on Ruby 3.2 / 3.3 Windows. |
Signed-off-by: Athishpranav2003 <athishanna@gmail.com>
Signed-off-by: Athishpranav2003 <athishanna@gmail.com>
|
@Athishpranav2003 Thanks so much for this improvement! The following would be necessary for us.
@Athishpranav2003 |
Sure will do it around this weekend or next week |
|
@daipom will default tls version stay as tls1.2? |
Thanks!!
Yes! Line 22 in eeb384e If we change this, it should be done in a separate PR. |
|
and @daipom what kinda tests to add to test_tls.rb? |
We want some tests for We already have tests for |
Signed-off-by: Athishpranav2003 <athishanna@gmail.com>
|
@daipom have added one test. If u have any idea of more tests please let me know |

Which issue(s) this PR fixes:
Fixes #4332
What this PR does / why we need it:
Changes the way we configure Net::HTTP client.
Docs Changes:
fluent/fluentd-docs-gitbook#579
Release Note:
The same as the title.