Backport(v1.16): gem: fix uri gem version to keep IPv6 tests (#5142)#5143
Closed
Watson1978 wants to merge 1 commit intov1.16from
Closed
Backport(v1.16): gem: fix uri gem version to keep IPv6 tests (#5142)#5143Watson1978 wants to merge 1 commit intov1.16from
Watson1978 wants to merge 1 commit intov1.16from
Conversation
**Which issue(s) this PR fixes**: Related to #5141 **What this PR does / why we need it**: Since uri 1.1.0, `Net::HTTP` will cause a `URI::InvalidComponentError` if we use IPv6 address. To avoid the error, this PR will fix uri version to 1.0.x. **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Contributor
Author
|
We added a dependency to uri gem on Fluentd 1.19 in #4774. So, Fluentd 1.16 does not need this backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #5142
Which issue(s) this PR fixes:
Related to #5141
What this PR does / why we need it:
Since uri 1.1.0,
Net::HTTPwill cause aURI::InvalidComponentErrorif we use IPv6 address.To avoid the error, this PR will fix uri version to 1.0.x.
Docs Changes:
Release Note: