Skip to content

feat(fluent-bit): add VPA controlledValues#619

Merged
stevehipwell merged 4 commits intofluent:mainfrom
larrywax:vpa-controlled-values
Jun 27, 2025
Merged

feat(fluent-bit): add VPA controlledValues#619
stevehipwell merged 4 commits intofluent:mainfrom
larrywax:vpa-controlled-values

Conversation

@larrywax
Copy link
Copy Markdown
Contributor

Allow customising VPA controlledValues option

Signed-off-by: Giuseppe D'Anna <giuseppe.danna@truelayer.com>
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @larrywax, before a PR can be merged the chart changes annotations need updating. Also could you please provide some more context with links to justify the changes?

@larrywax
Copy link
Copy Markdown
Contributor Author

Thanks for the PR @larrywax, before a PR can be merged the chart changes annotations need updating. Also could you please provide some more context with links to justify the changes?

Hi @stevehipwell, thanks for reviewing this PR. I'm sorry about the annotation, totally missed it.
Let me explain my company use case:
We use fluent-bit to parse and forward all the pods logs in our clusters. To accomodate higher load on biggest nodes, we have to set fairly high requests. The downside of this approach is that we waste quite a bit of resources on smaller nodes.
To solve this problem we would like to use VPA and leverage its InPlaceUpdate feature
Unfortunately, as stated in that doc, memory limit downscale requires a pod restart.
So, to wrap it up, we would like to instruct VPA to scale only the requests and leave the limits as we set them in the chart

Signed-off-by: Giuseppe D'Anna <giuseppe.danna@truelayer.com>
@larrywax larrywax force-pushed the vpa-controlled-values branch from 7a614a6 to c46cbe9 Compare June 25, 2025 21:36
Signed-off-by: Giuseppe D'Anna <giuseppe.danna@truelayer.com>
@larrywax larrywax force-pushed the vpa-controlled-values branch from ede6aa4 to 69374ee Compare June 27, 2025 13:36
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Giuseppe D'Anna <g.danna@live.it>
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit da19c2d into fluent:main Jun 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants