feat(fluent-bit): add securityContext to reloader pod#631
Merged
patrick-stephens merged 4 commits intofluent:mainfrom Sep 5, 2025
relusc:addSecurityContextReloader
Merged
feat(fluent-bit): add securityContext to reloader pod#631patrick-stephens merged 4 commits intofluent:mainfrom relusc:addSecurityContextReloader
patrick-stephens merged 4 commits intofluent:mainfrom
relusc:addSecurityContextReloader
Conversation
relusc
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
Signed-off-by: relusc <relusc@gmail.com>
stevehipwell
requested changes
Sep 5, 2025
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
I've added a comment on the implementation. FYI you also need to update the Chart.yaml file to bump the version and update the change annotations.
Signed-off-by: relusc <r.schach96@gmail.com>
stevehipwell
requested changes
Sep 5, 2025
added 2 commits
September 5, 2025 16:56
Signed-off-by: relusc <r.schach96@gmail.com>
Signed-off-by: relusc <r.schach96@gmail.com>
Collaborator
|
@patrick-stephens do you want to give this a second set of eyes? |
patrick-stephens
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
securityContextdefined in the values to the configmap-reloader container as well. This makes sure that also container-level attributes can be applied to the reloader (instead of only relying on inherited values from thepodSecurityContextinput).