Skip to content

Conversation

labsin
Copy link

@labsin labsin commented May 4, 2025

Adds a ContainSubtree overload with the Func<IJsonAssertionOptions<object>, IJsonAssertionOptions<object>> config parameter analogue with the BeEquivalentTo methods.

Fixes #78

@dennisdoomen dennisdoomen requested a review from Copilot September 7, 2025 10:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new ContainSubtree overload that accepts a configuration function parameter, providing users with more control over JSON assertion options similar to the existing BeEquivalentTo methods. This enhancement addresses issue #78 by allowing custom assertion configurations when checking JSON subtrees.

  • Adds a new ContainSubtree method overload with configurable assertion options
  • Includes comprehensive test coverage for float approximation scenarios
  • Updates XML documentation parameter name for clarity

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Src/FluentAssertions.Json/JTokenAssertions.cs Adds new ContainSubtree overload with config parameter and fixes XML doc parameter name
Tests/FluentAssertions.Json.Specs/JTokenAssertionsSpecs.cs Adds test cases for float approximation using the new ContainSubtree overload

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dennisdoomen dennisdoomen changed the title add ContainSubtree that takes a config Add ContainSubtree that takes a config Sep 28, 2025
@dennisdoomen dennisdoomen changed the title Add ContainSubtree that takes a config Add overload of ContainSubtree that takes a config Sep 28, 2025
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor suggestions. You do need to update the snapshot tests using the AcceptApiChanges.ps1 to make the build green.

Also, apologies for the late review.

@dennisdoomen dennisdoomen requested a review from jnyrup September 28, 2025 11:17
@labsin
Copy link
Author

labsin commented Sep 30, 2025

I also removed the bad copy-paste example doc and the misplaced end tag that the AI noticed

@labsin labsin requested a review from dennisdoomen September 30, 2025 07:04
@jnyrup
Copy link
Member

jnyrup commented Oct 2, 2025

The API update wasn't successful.
I guess you need to compile the project before running AcceptChanges.

Besides that - the changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainSubtree does not have an overload taking an options builder
3 participants