fix(Happy Hare): Fixed display of vendor logos and updated EMU svg #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MMU vendor logo display issues by adding a required height attribute to the SVG element and updates the EMU logo SVG file. It also adjusts padding for improved visual balance. However, there is a critical bug where debug code was accidentally left in.
- Added
height="100%"to inline-svg component to fix vendor logo rendering - Updated EMU logo SVG with new design from designer
- Adjusted padding values for better visual balance
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/widgets/mmu/MmuUnit.vue | Added height attribute to fix vendor logo display; adjusted padding for better visual balance |
| src/components/widgets/mmu/MmuFilamentStatus.vue | Contains critical bug - debug code left in lowerNozzleFull getter |
| public/img/mmu/mmu_EMU.svg | Complete replacement with new EMU logo design |
Signed-off-by: Pedro Lamas <[email protected]>
…ion into logo_fix
pedrolamas
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
MMU vendor logos were not displaying because of a missing element in the SVG. This fix adds that to where the logo is used.
It also updates the EMU logo at the designers request.
Finally it adjust pixel layout slightly for more balanced look
SIgned off by: Paul Morgan ([email protected])