Skip to content

Conversation

@moggieuk
Copy link
Contributor

Description:
This fixes a couple of cases where the (animated) position of the filament in the bowden was incorrect. It fixes the bug of reading gate_endstop where extruder_endstop should have been used.
It also greatly simplifies the component and removes private methods and unnecessary watchers.

Component modified:
Screenshot 2025-12-16 at 10 48 19 PM

SIgned off by: Paul Morgan ([email protected])

@moggieuk
Copy link
Contributor Author

@pedrolamas This PR is a combination bug fix and significant component code-cleanup. It is the last of the current batch of PRs. Thank you!

@pedrolamas pedrolamas requested a review from Copilot December 16, 2025 16:05
@pedrolamas pedrolamas added the GH - Bug Something isn't working label Dec 16, 2025
@pedrolamas pedrolamas added this to the 1.36.1 milestone Dec 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where configGateHomingEndstop was incorrectly used instead of configExtruderHomingEndstop when determining the end-of-bowden filament position, and significantly refactors the component by replacing watchers and imperative animation logic with reactive computed properties.

  • Fixes incorrect endstop configuration check causing wrong filament position calculation
  • Refactors from imperative watchers to reactive computed properties for cleaner state management
  • Simplifies animation logic with CSS transitions instead of programmatic animation

return POSITIONS.END_BOWDEN
}
get toolheadSensor () {
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should include undefined since accessing a non-existent key in the sensors Record returns undefined at runtime. This would improve type safety when using this getter. Consider changing the return type to boolean | null | undefined or adding a check like this.sensors['toolhead'] ?? null to match the declared type.

Suggested change
get toolheadSensor () {
get toolheadSensor (): boolean | null | undefined {

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore.

@pedrolamas pedrolamas merged commit a2ea72b into fluidd-core:develop Dec 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GH - Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants