fix(GcodePreview): use approximate position #1776
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the GcodePreview feature where binary search was returning exact matches only instead of approximate positions. The fix restores the previous behavior by enabling the approximate search mode.
- Adds
trueparameter tobinarySearchcall ingetMoveIndexByFilePositionto enable approximate position matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced with the changes from ce219df, where previously we were returning the approximate value from the binary search instead of the exact one as we were now, so this reverts back to the previous method.
Fix #1774