Skip to content

Conversation

geronimol
Copy link
Contributor

@geronimol geronimol commented Mar 18, 2025

Solution description

FormBuilderDateTimePicker
I have a use case where clicking the date should move the user to the next screen.
I've seen this as a PR here, but seems was rejected.

I created a copy of the date picker with the above customization. So setting popOnDateSelection to true will allow this behavior.
Let me know what you think about this, or if you think there is another way of doing this.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Collaborator

Hi! Thanks for contribution, but this current implementation can't be admit. Some problems here:

  • More code to maintain. The focus of this package is extend the components of Flutter, not create your own
  • This approach has some other points unresolved, like accesibility.

In another hand, I like add the property popOnDateSelection but only if can implement the feature in other way

@geronimol
Copy link
Contributor Author

@deandreamatias Thanks for your response. I couldn't think another way of doing this since the original PR was rejected. You can close this if you want.

@deandreamatias
Copy link
Collaborator

This is a strong argument to can't merge this
Also, after pick the date need to save on FormBuilderState.
Is a use case too specific.

You can create your own field and implement this variant, that also simplify to use only calendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants