Skip to content

Feature saved headlines #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 72 additions & 2 deletions lib/account/view/saved_headlines_page.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
import 'package:flutter/material.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:go_router/go_router.dart';
import 'package:ht_main/account/bloc/account_bloc.dart';
import 'package:ht_main/headlines-feed/widgets/headline_item_widget.dart';
import 'package:ht_main/l10n/l10n.dart';
import 'package:ht_main/router/routes.dart';
import 'package:ht_main/shared/widgets/widgets.dart';
import 'package:ht_shared/ht_shared.dart' show Headline;

/// {@template saved_headlines_page}
/// A placeholder page for displaying user's saved headlines.
/// Displays the list of headlines saved by the user.
///
/// Allows users to view details of a saved headline or remove it
/// from their saved list.
/// {@endtemplate}
class SavedHeadlinesPage extends StatelessWidget {
/// {@macro saved_headlines_page}
Expand All @@ -11,9 +21,69 @@ class SavedHeadlinesPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
final l10n = context.l10n;

return Scaffold(
appBar: AppBar(title: Text(l10n.accountSavedHeadlinesTile)),
body: const Center(child: Text('SAVED HEADLINES PAGE (Placeholder)')),
body: BlocBuilder<AccountBloc, AccountState>(
builder: (context, state) {
if (state.status == AccountStatus.loading &&
state.preferences == null) {
return LoadingStateWidget(
icon: Icons.bookmarks_outlined,
headline: 'Loading Saved Headlines...', // Placeholder
subheadline: 'Please wait while we fetch your saved articles.', // Placeholder
);
}

if (state.status == AccountStatus.failure &&
state.preferences == null) {
return FailureStateWidget(
message:
state.errorMessage ?? 'Could not load saved headlines.', // Placeholder
onRetry: () {
if (state.user?.id != null) {
context.read<AccountBloc>().add(
AccountLoadContentPreferencesRequested(
userId: state.user!.id,
),
);
}
},
);
}

final savedHeadlines = state.preferences?.savedHeadlines ?? [];

if (savedHeadlines.isEmpty) {
return InitialStateWidget(
icon: Icons.bookmark_add_outlined,
headline: 'No Saved Headlines', // Placeholder
subheadline: 'You haven\'t saved any articles yet. Start exploring!', // Placeholder
);
}

return ListView.separated(
itemCount: savedHeadlines.length,
separatorBuilder: (context, index) => const Divider(height: 1),
itemBuilder: (context, index) {
final headline = savedHeadlines[index];
return HeadlineItemWidget(
headline: headline,
targetRouteName: Routes.accountArticleDetailsName,
trailing: IconButton( // Changed from trailingWidget
icon: const Icon(Icons.delete_outline),
tooltip: 'Remove from saved', // Placeholder
onPressed: () {
context.read<AccountBloc>().add(
AccountSaveHeadlineToggled(headline: headline),
);
},
),
);
},
);
},
),
);
}
}
9 changes: 9 additions & 0 deletions lib/headlines-feed/widgets/headline_item_widget.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class HeadlineItemWidget extends StatelessWidget {
const HeadlineItemWidget({
required this.headline,
required this.targetRouteName, // Add targetRouteName
this.trailing, // Add optional trailing widget
super.key,
});

Expand All @@ -19,6 +20,9 @@ class HeadlineItemWidget extends StatelessWidget {
/// The named route to navigate to when the item is tapped.
final String targetRouteName; // Add targetRouteName

/// An optional widget to display at the end of the row.
final Widget? trailing;

// Helper for date formatting
static final _dateFormatter = DateFormat.yMd().add_jm();

Expand Down Expand Up @@ -159,6 +163,11 @@ class HeadlineItemWidget extends StatelessWidget {
],
),
),
// Add the trailing widget if provided
if (trailing != null) ...[
const SizedBox(width: AppSpacing.md),
trailing!,
],
],
),
),
Expand Down
16 changes: 16 additions & 0 deletions lib/router/router.dart
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,22 @@ GoRouter createRouter({
child: Center(child: Text('SAVED HEADLINES PAGE')),
);
},
routes: [
GoRoute(
path: Routes.accountArticleDetails, // 'article/:id'
name: Routes.accountArticleDetailsName,
builder: (context, state) {
final id = state.pathParameters['id']!;
return BlocProvider(
create: (context) => HeadlineDetailsBloc(
headlinesRepository:
context.read<HtDataRepository<Headline>>(),
)..add(HeadlineDetailsRequested(headlineId: id)),
child: HeadlineDetailsPage(headlineId: id),
);
},
),
],
),
],
),
Expand Down
4 changes: 4 additions & 0 deletions lib/router/routes.dart
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ abstract final class Routes {
static const manageFollowedItemsName = 'manageFollowedItems'; // Renamed
static const accountSavedHeadlines = 'saved-headlines';
static const accountSavedHeadlinesName = 'accountSavedHeadlines';
// New route for article details from saved headlines
static const String accountArticleDetails =
'article/:id'; // Relative to accountSavedHeadlines
static const String accountArticleDetailsName = 'accountArticleDetails';

// --- Manage Followed Items Sub-Routes (relative to /account/manage-followed-items) ---
static const followedCategoriesList = 'categories';
Expand Down
Loading