Feature settings enahancement and bug fixe #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BlocProvider wraps all settings routes - Provides SettingsBloc to children - Simplifies settings route structure
- Implemented font size setting - Implemented font family setting - Implemented font weight setting - Refreshes app settings on change
- Add base and accent theme options - Persist theme changes - Refresh app theme on change
- Added theme settings route - Added font settings route - Nested under appearance settings
- Added theme route - Added font route
…gsPage`) now serves as a menu, directing to two new sub-pages: - A page for "Theme Settings" (Base Theme, Accent Theme). - A page for "Font Settings" (Text Scale Factor, Font Family, Font Weight).
- Added locale to AppState - Mapped language code to Locale - Added default locale if not found
- Added fontWeight to theme data - Use locale from AppBloc state
- Added theme settings title - Added font settings title - Added language settings title
- Added language settings page route - Updated routes definitions
- Added SettingsLanguageChanged event - Updated SettingsBloc to handle event - Persists language setting
- Added Roboto font option - Added OpenSans font option - Added Lato font option - Added Montserrat font option - Added Merriweather font option
- Implemented language selection UI - Added language change event - Refreshes app settings on change
- Added language settings tile - Navigates to language settings page
- Added appFontWeight parameter - Applied font weight to body text - Support light, regular, and bold
- Added back button logic - Reordered settings tiles
- Added font weight to theme - Refactored themeing logic - Added debug prints for theme values
- Use fontFamily string directly - Remove GoogleFonts mapping - Log input and output
- Improved readability - Added 'SystemDefault' case - Handles null fontFamily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change