-
Notifications
You must be signed in to change notification settings - Fork 0
Fix search page #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search page #61
Conversation
- Update resolved-ref from abef81e to 7945773 in pubspec.lock
- Create TopicItemWidget to display Topic search results - Replace temporary ListTile with TopicItemWidget in search results - Add navigation to Topic details page on item tap
- Remove unused import of kIsWeb - Add imports for ht_ui_kit and timeago packages - Implement timeago localization for English and Arabic
- Add timeago package to dependencies - Replace custom date formatting with timeago.format() function
- Replace custom timestamp formatting with timeago package - Add import for timeago package - Update build method to use timeago.format() for createdAt date
- Replace placeholder timestamp with relative time using timeago package - Remove TODO comment about using a proper timeago library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the user experience of the search page and headline displays. It introduces a specialized widget for rendering topic search results, providing richer information and direct navigation. Additionally, it enhances the display of timestamps across various headline tiles by integrating a 'time ago' formatting library, making dates more intuitive for users.
Highlights
- Search Page Enhancements: Introduced a dedicated
TopicItemWidget
to properly display and handle navigation for 'Topic' search results within theHeadlinesSearchView
, replacing a genericListTile
and resolving a previousTODO
comment. - Date Formatting Improvement: Integrated the
timeago
library across various headline display widgets (headline_tile_image_start
,headline_tile_image_top
,headline_tile_text_only
) to show dates in a more user-friendly 'time ago' format (e.g., '5 minutes ago'), addressing existingTODO
comments for proper time formatting. - Code Clean-up: Removed an unused
kIsWeb
import fromlib/bootstrap.dart
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces topic search functionality and integrates the timeago package for date formatting. It also includes minor code improvements and widget updates.
Description
Type of Change