Fix fetching sorting #70
Conversation
- Update sort option in readAll method to include explicit ascending order - This ensures consistent behavior across different database implementations
- Add explicit SortOrder.asc to name sorting parameter - Ensures consistent sorting behavior in topic list retrieval
- Change the sort order from descending to ascending for country names - This ensures that the list of countries is displayed in alphabetical order
- Change the sort order from descending to ascending for both initial data load and subsequent fetches - This ensures topics are displayed in alphabetical order
- Change sort option from 'updatedAt' to 'name' - Update sort order from descending to ascending
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug by refining the data fetching sorting logic across various parts of the application. The changes ensure that lists of sources, topics, and countries are consistently presented in ascending order by their names, improving the overall data display and user experience.
Highlights
- Sorting Standardization: Ensured that data fetching for available sources and topics consistently uses
SortOrder.ascwhen sorting by 'name', explicitly defining the ascending order. - Country Filter Sorting Correction: Corrected the sorting logic for country filters in two instances: changing the initial fetch from descending by name to ascending by name, and fixing a subsequent fetch that incorrectly sorted by
updatedAtto now sort bynamein ascending order. - Topic Filter Sorting Consistency: Adjusted topic filter data fetching to consistently sort by 'name' in
SortOrder.ascacross multiplereadAllcalls.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses inconsistencies in data fetching and sorting across several BLoCs. The changes correctly align the sorting logic to be consistently by name in ascending order, which fixes a clear bug where loading more items used a different sorting key. I've added a couple of suggestions to improve maintainability by reducing code duplication for the sort options. Overall, this is a good fix.
Description
Type of Change