Feature maintainance mode #71
Conversation
…checks - Add AppStatusService to monitor app lifecycle and trigger status checks - Integrate with AppBloc for fetching app configuration - Implement periodic checks using Timer for real-time status updates - Register as WidgetsBindingObserver to listen for app resume events - Include cleanup method to dispose resources properly
- Add AppStatusService for periodic and event-driven status checks - Integrate AppStatusService with AppBloc and GoRouter - Ensure automatic status updates when the app is resumed - Implement proper disposal of AppStatusService to prevent memory leaks
- Create a new MaintenancePage widget to display when the app is in maintenance mode - Use UI kit components for consistent look and feel - Implement localized strings for headline and subheadline - Add padding and layout structure using Scaffold
- Replace direct context extension with explicit AppLocalizations call - Add import for AppLocalizations class
- Add English translations for maintenance page headline and subheadline - New strings include: - "maintenanceHeadline": "Under Maintenance" - "maintenanceSubheadline": "We are currently performing maintenance. Please check back later."
- Add Arabic translations for "maintenanceHeadline" and "maintenanceSubheadline" - Maintain consistency in translation format and style
- Add new translations for update required headline, subheadline, and button - Maintain consistent formatting and structure in app_en.arb file
- Add Arabic translations for force update page headline, subheadline, and button text - Maintain consistent formatting and structure in app_ar.arb file
- Remove unused import statement for l10n.dart - Keep import for app_localizations.dart as it might be necessary for localization
- Implement UpdateRequiredPage widget for mandatory app updates - Add logic to launch app store URL for update - Display error message if update URL is unavailable - Use AppBloc to fetch remote config for platform-specific update URLs - Reuse InitialStateWidget for consistent UI
- Add MaintenancePage and UpdateRequiredPage to app dependencies - Implement global checks for maintenance mode and required updates - Prioritize these checks above RemoteConfig loading states - Lock UI if app is under maintenance or requires an update
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a robust and proactive system for managing application status, specifically addressing maintenance mode and mandatory updates. By integrating a new AppStatusService that monitors app lifecycle and periodically checks remote configurations, the application can now dynamically respond to server-side directives. This ensures that users are immediately informed and guided when the app is under maintenance or requires an update, significantly improving the user experience and application stability.
Highlights
- New App Status Service: Introduced
AppStatusServiceto proactively monitor application lifecycle events and periodically fetch remote configuration, ensuring the app can react to server-side status changes (like maintenance or forced updates) in real-time. - Global Maintenance Mode Handling: Implemented a global
MaintenancePagethat automatically displays and blocks all other UI when the app's status isunderMaintenance, providing a clear message to the user. - Global Forced Update Handling: Added a global
UpdateRequiredPagethat prompts users to update the app whenupdateRequiredstatus is detected, including a button to directly open the relevant app store. - Enhanced Localization: Extended localization files to include new strings for the maintenance and update required pages, supporting internationalization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable maintenance mode feature, including a new AppStatusService for periodic status checks and dedicated pages for maintenance and required updates. The implementation is well-thought-out.
My feedback focuses on improving the robustness and maintainability of the new code. I've highlighted a high-severity issue regarding the use of BuildContext in the new service and provided a refactoring suggestion. Additionally, I've made a few medium-severity recommendations to reduce code duplication and ensure all user-facing strings are properly localized. Overall, this is a solid contribution.
Description
Type of Change