Skip to content

Fix duplicate table entry #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2025
Merged

Fix duplicate table entry #20

merged 5 commits into from
Jul 4, 2025

Conversation

fulleni
Copy link
Member

@fulleni fulleni commented Jul 4, 2025

Status

READY/IN DEVELOPMENT/HOLD

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@fulleni fulleni merged commit 86e3ac6 into main Jul 4, 2025
1 check failed
@fulleni fulleni deleted the fix_duplicate_table_entry branch July 4, 2025 05:15
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of content management by changing how newly created items are reflected in the UI. By switching from direct local state manipulation to a full data reload, it ensures that the displayed lists of headlines, categories, and sources are always synchronized with the backend, thereby preventing the occurrence of duplicate entries.

Highlights

  • Bug Fix: Duplicate Entries: This pull request addresses a potential issue where duplicate entries might appear in content management tables (headlines, categories, sources) after new items are created.
  • State Management Refinement: The approach for updating the UI after creating new content items has been refined. Instead of directly adding the new item to the local state, the system now triggers a full reload of the relevant data list, ensuring consistency with the backend.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug that caused duplicate entries when creating new content items. The solution involves refreshing the data from the server after each creation, ensuring data consistency.

Comment on lines 84 to 87
context.read<ContentManagementBloc>().add(
CategoryAdded(state.createdCategory!),
// Refresh the list to show the new category
const LoadCategoriesRequested(limit: kDefaultRowsPerPage),
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The code now reloads the categories after creating a new one. While this fixes the duplicate entry issue, it might not be the most efficient approach. Consider updating the local state directly with the new category if the API returns the created category object.

Comment on lines 86 to 89
context.read<ContentManagementBloc>().add(
HeadlineAdded(state.createdHeadline!),
// Refresh the list to show the new headline
const LoadHeadlinesRequested(limit: kDefaultRowsPerPage),
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The code now reloads the headlines after creating a new one. While this fixes the duplicate entry issue, it might not be the most efficient approach. Consider updating the local state directly with the new headline if the API returns the created headline object.

Comment on lines 86 to 89
context.read<ContentManagementBloc>().add(
SourceAdded(state.createdSource!),
// Refresh the list to show the new source
const LoadSourcesRequested(limit: kDefaultRowsPerPage),
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The code now reloads the sources after creating a new one. While this fixes the duplicate entry issue, it might not be the most efficient approach. Consider updating the local state directly with the new source if the API returns the created source object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant